aditya-gupta36 opened a new pull request, #373:
URL: https://github.com/apache/atlas/pull/373

   ## What changes were proposed in this pull request?
   - Initially under basic and classification search, only basic [Add filter] 
option on UI,  validation was done. Also, for [Add Group FIlter]option on UI  
it was throwing exception and errors.
   - So in this PR we have fixed that issue and we have handled filter search 
validation for both basic and complex filter groups.
   - Group FIlter - it recursively calls Filter SearchParameters. eg: In 
FilterCriteria class we have List<FilterCriteria> criterion, so entityFilters 
attribute in SearchParametrs class recursively calls criterion in itself 
multiple times.
   - Apart have added TC to test negative scenarios for quick search and basic 
search
   
   
   Conclusion:
   - As one can see, inside entity filter, we have criterion which in itself 
has condition and criterion i.e following nested pattern[recursively filtered], 
si in such case it gives: 
   {
       "errorCode": "ATLAS-400-00-103",
       "errorMessage": "Invalid operator specified for attribute: null"
   }
   
   So we have fixed this Complex filter validation[i.e. Add Filter Group 
Option]. Earlier it was only able to handle basic filter[i.e. normal Add Filter 
Option]
    
   ## How was this patch tested?
   - Curl Request
   - Postman Request
   - UI testing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to