pinal-shah commented on code in PR #374:
URL: https://github.com/apache/atlas/pull/374#discussion_r2179936584
##########
authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java:
##########
@@ -76,7 +79,7 @@ public AtlasEntityAccessRequest(AtlasTypeRegistry
typeRegistry, AtlasPrivilege a
this.businessMetadata = businessMetadata;
this.attributeName = attributeName;
this.typeRegistry = typeRegistry;
- this.entityClassifications = super.getClassificationNames(entity);
+ this.entityClassifications = (entity != null &&
CollectionUtils.isNotEmpty(entity.getClassificationNames())) ? new
HashSet<>(entity.getClassificationNames()) : Collections.emptySet();
Review Comment:
This change is necessary, so as to avoid using below
`entityRetriever.toAtlasEntityHeaderWithClassifications
`instead we can make use of
`entityRetriever.toAtlasEntityHeader` wherever possible, which will avoid
extra edge traversal call to find classification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
