aditya-gupta36 commented on code in PR #397:
URL: https://github.com/apache/atlas/pull/397#discussion_r2218926704


##########
webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java:
##########
@@ -163,17 +171,12 @@ public void init(FilterConfig filterConfig) throws 
ServletException {
      */
     @Override
     public void doFilter(ServletRequest servletRequest, ServletResponse 
servletResponse, FilterChain filterChain) throws IOException, ServletException {
+        setSsoEnabled(false);
         HttpServletResponse         httpResponse    = (HttpServletResponse) 
servletResponse;
         AtlasResponseRequestWrapper responseWrapper = new 
AtlasResponseRequestWrapper(httpResponse);
 
         HeadersUtil.setSecurityHeaders(responseWrapper);
 
-        if (!ssoEnabled) {
-            filterChain.doFilter(servletRequest, servletResponse);
-
-            return;
-        }
-
         HttpServletRequest httpRequest = (HttpServletRequest) servletRequest;
 
         if (LOG.isDebugEnabled()) {

Review Comment:
   Removed



##########
webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java:
##########
@@ -187,12 +190,6 @@ public void doFilter(ServletRequest servletRequest, 
ServletResponse servletRespo
             return;
         }
 
-        if (jwtProperties == null || isAuthenticated()) {
-            filterChain.doFilter(servletRequest, servletResponse);
-
-            return;
-        }
-
         if (LOG.isDebugEnabled()) {

Review Comment:
   Removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to