DishaTalreja3 commented on code in PR #406:
URL: https://github.com/apache/atlas/pull/406#discussion_r2323524368
##########
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java:
##########
@@ -162,6 +164,10 @@ public class AdminResource {
private static final List<String> TIMEZONE_LIST =
Arrays.asList(TimeZone.getAvailableIDs());
private static final String METRICS_PERSIST_INTERVAL =
"atlas.metrics.persist.schedule";
private static final String METRICS_PERSIST_INTERVAL_DEFAULT = "0 0
0/1 * * *"; // 1 hour interval
+ private static final String PURGE_CRON_EXPRESSION =
"atlas.purge.cron.expression";
+ private static final String PURGE_CRON_EXPRESSION_DEFAULT = "* *
* 30 2 ?";
Review Comment:
This cron expression "* * * 30 2 ?" looks invalid because February 30th
doesn’t exist. Can you please check if this is right?
Also, it would be good to add a comment about what the schedule is supposed
to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
