jayendrap commented on code in PR #497:
URL: https://github.com/apache/atlas/pull/497#discussion_r2698010261


##########
webapp/pom.xml:
##########
@@ -544,7 +539,7 @@
                             <addClasspath>true</addClasspath>
                         </manifest>
                     </archive>
-                    
<packagingExcludes>WEB-INF/lib/dom4j-*.jar,${packages.to.exclude}</packagingExcludes>
+                    
<packagingExcludes>WEB-INF/lib/dom4j-*.jar,WEB-INF/lib/jsp-api*.jar,${packages.to.exclude}</packagingExcludes>

Review Comment:
   Yes, it is required because jsp-api jar still gets transitively included 
from hadoop-common dependency.
   We can explicitly exclude from hadoop-common, but I would still keep this 
exclude, so that if any other dependency pulls jsp-api, then it doesn't gets 
bundled in final war file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to