Copilot commented on code in PR #530:
URL: https://github.com/apache/atlas/pull/530#discussion_r2823352626
##########
graphdb/janus/pom.xml:
##########
@@ -80,14 +85,20 @@
<version>${commons-text.version}</version>
</dependency>
<dependency>
- <groupId>org.apache.hbase</groupId>
- <artifactId>hbase-shaded-client</artifactId>
- <version>${hbase.version}</version>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-distcp</artifactId>
+ <version>${hadoop.version}</version>
</dependency>
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-shaded-mapreduce</artifactId>
- <version>${hbase.version}</version>
+ <version>${hbase.version}-hadoop3</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-distcp</artifactId>
+ </exclusion>
Review Comment:
The hbase-shaded-mapreduce-hadoop3 dependency likely has a transitive
dependency on hbase-shaded-client-hadoop3, which would conflict with the
hbase-shaded-client-fixed dependency added at lines 54-58. Consider adding an
exclusion for hbase-shaded-client from hbase-shaded-mapreduce to ensure only
the fixed version is used. This would prevent potential classpath conflicts
between the original and fixed versions of the client library.
```suggestion
</exclusion>
<exclusion>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-shaded-client-hadoop3</artifactId>
</exclusion>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
