Copilot commented on code in PR #590:
URL: https://github.com/apache/atlas/pull/590#discussion_r3042320289
##########
release-build.xml:
##########
@@ -69,22 +69,22 @@
<arg value="${release-dir}/${build-release-tar-file}" />
</exec>
- <exec executable="gpg"
output="${release-dir}/${build-release-tar-file}.md5">
+ <exec executable="gpg"
output="${release-dir}/${build-release-tar-file}.md5" dir="${release-dir}">
<arg value="--print-md" />
<arg value="MD5" />
- <arg value="${release-dir}/${build-release-tar-file}" />
+ <arg value="${build-release-tar-file}" />
</exec>
Review Comment:
The MD5/SHA* checksum generation now runs in `${release-dir}` so the output
filenames won’t be prefixed with `target/`, but the legacy `.mds` checksum
generation still runs `gpg --print-mds` against
`${release-dir}/${build-release-tar-file}` (release-build.xml:67-70). That will
continue to emit `target/<tarball>:` in the `.mds` file, so the ATLAS-5263
formatting issue is only partially resolved. Consider applying the same
`dir="${release-dir}"` + `${build-release-tar-file}` argument change to the
`.mds` exec (or removing `.mds` generation if it’s no longer used).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
