sarathsubramanian commented on code in PR #686:
URL: https://github.com/apache/atlas/pull/686#discussion_r3568281665
##########
intg/pom.xml:
##########
@@ -154,6 +154,31 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>3.1.0</version>
+ <executions>
+ <execution>
+ <id>python-test</id>
Review Comment:
we are introducing python-tests to be run in addition to the java test
suites during maven build. This could potentially fail for certain users who
don't have python installed or have the right python version that atlas
expects.
should we gate this behind a maven profile -Ppython-tests turning it OFF by
default and run only for useers who opt to test python test cases.
##########
intg/pom.xml:
##########
@@ -154,6 +154,31 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>3.1.0</version>
+ <executions>
+ <execution>
+ <id>python-test</id>
+ <goals>
+ <goal>exec</goal>
+ </goals>
+ <phase>test</phase>
+ <configuration>
+ <skip>${skipTests}</skip>
+ <executable>python3</executable>
Review Comment:
python3 may not work on windows. please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
