pawarprasad123 opened a new pull request, #723:
URL: https://github.com/apache/atlas/pull/723
## What changes were proposed in this pull request?
When creating or editing a custom entity whose attributes use an Atlas ENUM
typedef (e.g. ozone_storage_type), the UI previously rendered plain text
inputs. Users had to type enum values manually with no guidance on valid
options.
This patch adds dropdown rendering for ENUM-typed attributes in both UIs:
React v3 (dashboard/) — Create/Edit Entity modal via EntityForm
Backbone v2 (dashboardv2/) — Create/Edit Entity modal via
CreateEntityLayoutView
Behavior now matches existing enum handling in Business Metadata and
Classification tag forms.
## Problem
CreateEntityLayoutView.getElement() did not check enumDefCollection for ENUM
types; unsupported types fell through to getInput().
CreateEntityLayoutView did not receive enumDefCollection from parent views
that already had it loaded.
React EntityForm had the same gap — no enum-aware control selection.
## How was this patch tested?
Manual tested
Automated tests
All tests pass locally:
```
cd dashboard
npm run typecheck # Pass
npm run lint # Pass (0 errors)
npm run build # Pass
npm test --
--testPathPattern="EntityForm|EntityFormEnum|enumTypeUtils|entityTypeConfigUtils|FormEnumMultiSelect|FormSingleSelect|AttributeProperties"
# 178 tests passed across 9 suites
```
- Enum single-select dropdown for Create/Edit Entity (v2 + v3)
- Enum multi-select for array<enumType>
- Optional enum placeholder / empty selection
- Edit pre-selects stored value
- No regression for primitives, boolean, date, struct, map, entity refs
- Typecheck, lint, and build pass
- Apache 2.0 license headers on all new files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
