pareshddevalia commented on code in PR #720:
URL: https://github.com/apache/atlas/pull/720#discussion_r3755646738


##########
intg/src/test/java/org/apache/atlas/model/discovery/TestQuickSearchParameters.java:
##########
@@ -306,15 +307,15 @@ public void testEmptyAttributesSet() {
 
     @Test
     public void testAttributesSetModification() {
-        Set<String> attributes = new HashSet<>();
+        List<String> attributes = new ArrayList<>();
         attributes.add("initialAttribute");
         searchParameters.setAttributes(attributes);
 
         attributes.add("additionalAttribute");
 
-        assertEquals(searchParameters.getAttributes().size(), 2);
+        assertEquals(searchParameters.getAttributes().size(), 1);
         
assertTrue(searchParameters.getAttributes().contains("initialAttribute"));
-        
assertTrue(searchParameters.getAttributes().contains("additionalAttribute"));
+        
assertFalse(searchParameters.getAttributes().contains("additionalAttribute"));

Review Comment:
   Added the UT for JSON deserialization tests for QuickSearchParameters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to