achandel-01 commented on code in PR #768:
URL: https://github.com/apache/atlas/pull/768#discussion_r4186325678
##########
webapp/src/main/java/org/apache/atlas/notification/SerialEntityProcessor.java:
##########
@@ -506,6 +506,11 @@ public TopicPartitionOffsetResult handleMessage(Ticket
ticket) {
String.format(AtlasClientV2.API_V2.UPDATE_ENTITY_BY_ATTRIBUTE.getNormalizedPath(),
partialUpdateRequest.getTypeName()));
}
+ if
(isIgnoredByConfiguredPattern(partialUpdateShell(partialUpdateRequest.getTypeName(),
partialUpdateRequest.getAttribute(),
partialUpdateRequest.getAttributeValue()), kafkaMsg)
+ || (entities != null &&
CollectionUtils.isNotEmpty(entities.getEntities()) &&
isIgnoredByConfiguredPattern(entities.getEntities().get(0), kafkaMsg))) {
Review Comment:
no I was saying for cases other than ENTITY_CREATE_V2 and
ENTITY_FULL_UPDATE_V2 when preprocessor context is initaliazed at that time
entitiesWithExtInfo is set to null (inside `preProcessNotificationMessage`
method) at that time.So for which case your second condidtion will hold ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
