mneethiraj commented on code in PR #786:
URL: https://github.com/apache/atlas/pull/786#discussion_r4299246070
##########
dev-support/atlas-docker/config/atlas/postgres/atlas-application.properties:
##########
@@ -79,6 +79,13 @@ atlas.authentication.method.file=true
atlas.authentication.method.ldap.type=none
atlas.authentication.method.file.filename=${sys:atlas.home}/conf/users-credentials.properties
+######### Header Based Authentication #########
+atlas.authentication.method.header.enabled=true
+atlas.authentication.method.header.username=x-awc-username
Review Comment:
Update following property values:
- `x-awc-username` => `X-Forwarded-User`
- `x-awc-request-id` => `X-Request-Id`
- `x-upstream, x-awc-source-workload-id` => `X-Spiffe-Id`
##########
dev-support/atlas-docker/config/atlas/postgres/atlas-application.properties:
##########
@@ -79,6 +79,13 @@ atlas.authentication.method.file=true
atlas.authentication.method.ldap.type=none
atlas.authentication.method.file.filename=${sys:atlas.home}/conf/users-credentials.properties
+######### Header Based Authentication #########
+atlas.authentication.method.header.enabled=true
+atlas.authentication.method.header.username=x-awc-username
+atlas.authentication.method.header.roles=x-awc-roles
+atlas.authentication.method.header.request-id=x-awc-request-id
Review Comment:
Equivalent Ranger property name uses `requestid` instead of `request-id`. I
suggest using the same property name here as well. Ref:
[RangerHeaderPreAuthFilter.java](https://github.com/apache/ranger/blob/master/security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerHeaderPreAuthFilter.java#L60).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
