[ 
https://issues.apache.org/jira/browse/ATLAS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588335#comment-14588335
 ] 

Jonathan Maron commented on ATLAS-15:
-------------------------------------

I will remove the version, though if you will note, version "0.1" is simply a 
default should the "project.version" property be unavailable.

[~shwethags] - I can not do that.  I do not currently have the knowledge (I 
have actually never received any explanation of the core functionality) nor the 
time to create client tests and then secure them.  Rather, I made sure that 
there was test coverage provided by leveraging the only tests that currently 
exist that make use of the metadata client (the hive hook tests).  If you wish 
to create a set of pure, non hive-hook metadata client tests I will gladly add 
the secure versions.

> Remove hard-coding of project version in tests
> ----------------------------------------------
>
>                 Key: ATLAS-15
>                 URL: https://issues.apache.org/jira/browse/ATLAS-15
>             Project: Atlas
>          Issue Type: Bug
>            Reporter: Shwetha G S
>             Fix For: 0.5-incubating
>
>
> {noformat}
> atlas$ git grep 0.1-incubating
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/BaseSSLAndKerberosTest.java:
>                 System.getProperty("project.version", 
> "0.1-incubating-SNAPSHOT"));
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/SSLHiveHookIT.java:
>                 System.getProperty("project.version", 
> "0.1-incubating-SNAPSHOT"));
> client/src/test/java/org/apache/atlas/security/BaseSecurityTest.java:         
>        System.getProperty("release.version", "0.1-incubating-SNAPSHOT"));
> webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerITBase.java:
>                 .format("/target/atlas-webapp-%s", 
> System.getProperty("project.version", "0.1-incubating-SNAPSHOT"));
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to