[
https://issues.apache.org/jira/browse/ATLAS-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717942#comment-14717942
]
ASF GitHub Bot commented on ATLAS-90:
-------------------------------------
Github user vkadam commented on a diff in the pull request:
https://github.com/apache/incubator-atlas/pull/6#discussion_r38167128
--- Diff: dashboard/v2/.bowerrc ---
@@ -1,5 +1,5 @@
{
- "directory": "dist/lib",
+ "directory": "public/lib",
--- End diff --
Why it should be in target? Its required runtime and not only compile time
like java classes. While creation of war dist folder gets added to it. Dist
folder is create from public folder with minified files.
If we move it to target folder then every mvn clean it will get deleted and
which will need bower to download it again. Which defeats the purpose of whole
offline build support.
> Support offline builds
> ----------------------
>
> Key: ATLAS-90
> URL: https://issues.apache.org/jira/browse/ATLAS-90
> Project: Atlas
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Vishal Kadam
> Priority: Minor
> Fix For: 0.6-incubating
>
> Attachments: 6.patch.txt, ATLAS-90.patch
>
>
> Currently, frontend-maven-plugin doesn't work without internet. Can we use
> https://github.com/allegro/grunt-maven-plugin to support offline builds?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
