> On Oct. 12, 2015, 5:36 a.m., Shwetha GS wrote:
> > repository/pom.xml, line 49
> > <https://reviews.apache.org/r/38341/diff/4/?file=1095124#file1095124line49>
> >
> > Lets avoid adding this dependency. I think this is required for
> > notification listener?
> >
> > Lets define the listener in notification module and register the
> > listener in webapp? The problem with adding dependency is, every UT needs
> > notification and increases debugging problems.
So then its okay to make notification dependent on repository (for the
EntityChangeListener interface)? It seems like notification is very heavy in
that it depends on every other module.
Also, it looks like the singleton DefaultMetaDataService is injected into the
resources in webapp. Where exactly should the listener registration be done?
@Inject
private MetadataService metadataService;
Also, the listener registration is not exposed on the MetadataService
interface. Should it be? I guess it has to be.
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38341/#review102205
-----------------------------------------------------------
On Oct. 12, 2015, 4:25 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38341/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 4:25 a.m.)
>
>
> Review request for atlas, John Speidel and Shwetha GS.
>
>
> Bugs: ATLAS-158, ATLAS-215 and ATLAS-217
> https://issues.apache.org/jira/browse/ATLAS-158
> https://issues.apache.org/jira/browse/ATLAS-215
> https://issues.apache.org/jira/browse/ATLAS-217
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Add entity change notification to Atlas based using the existing
> atlas-notification module.
>
>
> Diffs
> -----
>
> notification/pom.xml 2e12520
> notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java
> 7b3cf89
>
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java
> PRE-CREATION
>
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationConsumer.java
> PRE-CREATION
>
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationConsumerProvider.java
> PRE-CREATION
>
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java
> PRE-CREATION
>
> notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java
> 735655c
>
> notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationConsumerProviderTest.java
> PRE-CREATION
>
> notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationConsumerTest.java
> PRE-CREATION
>
> notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java
> PRE-CREATION
> repository/pom.xml 89d848c
> repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java
> 34f2ba3
>
> repository/src/main/java/org/apache/atlas/listener/EntityChangeListener.java
> 6465e92
>
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
> ea39f92
>
> repository/src/main/java/org/apache/atlas/services/NotificationEntityChangeListener.java
> PRE-CREATION
>
> repository/src/test/java/org/apache/atlas/TestRepositoryMetadataModuleFactory.java
> PRE-CREATION
>
> repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java
> db51ae5
>
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
> bec3067
>
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java
> 3c22815
>
> repository/src/test/java/org/apache/atlas/services/DefaultMetadataServiceTest.java
> PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/EntityImpl.java
> PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/IdImpl.java
> PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/TraitImpl.java
> PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/api/Entity.java
> PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/api/Id.java
> PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/api/Trait.java
> PRE-CREATION
> typesystem/src/test/java/org/apache/atlas/typesystem/EntityImplTest.java
> PRE-CREATION
> typesystem/src/test/java/org/apache/atlas/typesystem/IdImplTest.java
> PRE-CREATION
> typesystem/src/test/java/org/apache/atlas/typesystem/TraitImplTest.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38341/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
> All existing tests pass.
>
> New unit tests added.
>
>
> Thanks,
>
> Tom Beerbower
>
>
