[
https://issues.apache.org/jira/browse/ATLAS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979822#comment-14979822
]
Suma Shivaprasad commented on ATLAS-136:
----------------------------------------
[~vantonevich] Pls change status of issues whenever patch is uploaded to "Patch
Available" which helps us track it in the queue.
A couple of minor comments
1. use AtlasServiceException instead of AtlasException like elsewhere in
AtlasClient
2. Pls Use constants whereever possible which is exposed in AtlasClient like
RESULTS
3. CallAPIWithResource can be used instead of clientResponseWith and
toJsonObject methods. They are duplicating the current code. Similarly
getResource instead of traitReuseForGuid
4. Use the API enums already defined for Traits
> Add trait API to org.apache.atlas.AtlasClient
> ---------------------------------------------
>
> Key: ATLAS-136
> URL: https://issues.apache.org/jira/browse/ATLAS-136
> Project: Atlas
> Issue Type: Improvement
> Affects Versions: 0.6-incubating
> Reporter: Vladimir Antonevich`
> Fix For: 0.6-incubating
>
> Attachments: atlas.client.patch
>
>
> API to manipulate entity traits must be added to
> org.apache.atlas.AtlasClient. These should include methods to add/remove a
> trait POST/DELETE to /api/atlas/entities/{guid}/traits[/traitName], as
> supported by exposed entities resource
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
