[ 
https://issues.apache.org/jira/browse/ATLAS-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059404#comment-15059404
 ] 

David Kantor edited comment on ATLAS-122 at 12/16/15 3:03 AM:
--------------------------------------------------------------

[~suma.shivaprasad] I had already started working on sub-task Atlas-370 last 
week and have a working implementation which I'm in the process of testing.  
Deletes are cascaded through composite references.  In doing so, I have 
addressed issues in the existing update code which neglected to delete any 
structs or traits owned by the composite entities.  In addition, deletes are 
cascaded down through n-levels of composition - the existing code stopped at 
the first level.   I have attached a tar file with the changes I have applied 
so far, and a patch file which shows the diffs.

I have initially exposed delete through MetadataRepository as a GUID-based 
operation, i.e.   List <String> deleteEntities(String... guids)
The idea here is to avoid requiring client applications from having to retrieve 
full entities they wish to delete.  We could certainly add another entry point 
for an entity-based operation.

With regard to the hive model, it looks like HIVE_TABLE.partitionKeys is 
already defined as a composite reference in 
HiveDataModelGenerator.createTableClass().  Please let me know about other hive 
model changes that are needed.


was (Author: dkantor):
I had already started working on sub-task Atlas-370 last week and have a 
working implementation which I'm in the process of testing.  Deletes are 
cascaded through composite references.  In doing so, I have addressed issues in 
the existing update code which neglected to delete any structs or traits owned 
by the composite entities.  In addition, deletes are cascaded down through 
n-levels of composition - the existing code stopped at the first level.   I 
have attached a tar file with the changes I have applied so far, and a patch 
file which shows the diffs.

I have initially exposed delete through MetadataRepository as a GUID-based 
operation, i.e.   List <String> deleteEntities(String... guids)
The idea here is to avoid requiring client applications from having to retrieve 
full entities they wish to delete.  We could certainly add another entry point 
for an entity-based operation.

With regard to the hive model, it looks like HIVE_TABLE.partitionKeys is 
already defined as a composite reference in 
HiveDataModelGenerator.createTableClass().  Please let me know about other hive 
model changes that are needed.

> Support for Deletion of Entities
> --------------------------------
>
>                 Key: ATLAS-122
>                 URL: https://issues.apache.org/jira/browse/ATLAS-122
>             Project: Atlas
>          Issue Type: New Feature
>            Reporter: Suma Shivaprasad
>            Assignee: David Kantor
>         Attachments: changes.tar
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to