[
https://issues.apache.org/jira/browse/ATLAS-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120900#comment-15120900
]
Shwetha G S commented on ATLAS-199:
-----------------------------------
[~sanjayp], I am ok with these changes.
[~Sreenath], mvn clean is not required at each build, which means mvn clean is
an option to do clean build if one wants to download fresh. mvn install will
work just like downloading to dist(outside of target). The issues with
downloading to dist(outside of target) are:
1. If someone wants to do fresh download(because the js dependency versions are
changed etc), they have to know that dist is the target and have to delete it
manually. Since target is the standard mvn destination directory, just a mvn
clean will take care of it
2. The checked in files(which include js files etc) go through some standard
checks like apache header etc. But the downloaded files don't need to go
through these checks and they are exempted globally(as target is excluded).
Now, dist needs to be manually excluded
Since npm, bower run in the context of mvn which is the main build tool and mvn
is the only one that users use directly, we should stick to the mvn
conventions. Makes sense?
> webapp build fails (grunt + tests)
> ----------------------------------
>
> Key: ATLAS-199
> URL: https://issues.apache.org/jira/browse/ATLAS-199
> Project: Atlas
> Issue Type: Bug
> Affects Versions: 0.6-incubating
> Reporter: Erik Bergenholtz
> Assignee: Sanjay Patel
> Priority: Critical
> Labels: ATLAS-UI-BUGS
> Fix For: trunk
>
> Attachments: ATLAS-199-v0.patch, ATLAS-199-v1.patch
>
>
> When building Atlas webapp, I see the following issues:
> mvn clean install:
> {code}
> [INFO] Running 'grunt bower --no-color' in
> /Users/ebergenholtz/git3/incubator-atlas/dashboard
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 34.282 s
> [INFO] Finished at: 2015-09-30T13:55:30-05:00
> [INFO] Final Memory: 35M/420M
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> com.github.eirslett:frontend-maven-plugin:0.0.23:grunt (install bower) on
> project atlas-webapp: Failed to run task: 'grunt bower --no-color' failed.
> java.io.IOException: Cannot run program
> "/Users/ebergenholtz/git3/incubator-atlas/dashboard/node/node" (in directory
> "/Users/ebergenholtz/git3/incubator-atlas/dashboard"): error=2, No such file
> or directory -> [Help 1]
> {code}
> Also, if I bypass the grunt task some of the tests fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
