[ 
https://issues.apache.org/jira/browse/ATLAS-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180638#comment-15180638
 ] 

Erik Bergenholtz commented on ATLAS-500:
----------------------------------------

Hi [~sanjayp] - 

A few minor nits on the patch:
- The font size that shows "Invalid DSL Syntax, Click Here To Execute As A Text 
Search." and "3 Results Matching Your Fulltext Search Query Hive Were F..." is 
too large. I would like for the font size to be reduced and equal to the rest 
of the text.
- If I click on a tag (i.e. ETL in your example), I see the text "4 Results 
Matching Your Dsl Search Query ETL Were Found". "Dsl" should be DSL (all caps) 
and this looks like to be a different string that also should be reduced in 
size as per above.
- The hint text for Text search ("Search using a query string: sales_fact") 
should say "Search using a query string: e.g. sales_fact" (sorry I missed this 
above).




> UI: Search Default
> ------------------
>
>                 Key: ATLAS-500
>                 URL: https://issues.apache.org/jira/browse/ATLAS-500
>             Project: Atlas
>          Issue Type: Improvement
>    Affects Versions: 0.7-incubating
>            Reporter: Erik Bergenholtz
>            Assignee: Sanjay Patel
>             Fix For: 0.7-incubating
>
>         Attachments: ATLAS-500-error.png, ATLAS-500-v0.patch, 
> ATLAS-500-v1.patch
>
>
> The UI should provide a means of selecting the type of search performed. The 
> UI should not default to a fulltext search unless explicitly directed by the 
> user. This can be confusing to the user.
> If the DSL search does no result in any 'hits', it should so indicate.
> The search bar should provide a means by which the user can specify what type 
> of search to perform. One of:
> - DSL
> - FreeText
> (Gremlin should not be offered as an option through the UI)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to