> On April 12, 2016, 7:51 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java, > > line 111 > > <https://reviews.apache.org/r/46011/diff/2/?file=1341481#file1341481line111> > > > > Can you pls explain how deletion of edges works with soft deletes? I > > noticed that in case of isComposite alone we are deleting the edges > > forcefully(force flag) where in case of struct, array, map - this is not > > the case. I had assumed that in case of soft deletes we will not delete > > the edges even in teh case of composites
Introduced state on edges and edges are marked as deleted. There is also create time and last modified time on edges. We can actually get point in time entity state using this and entity audit For composite array attributes, only the active references are returned. For example, for hive_table, only active columns are returned For non-composite array attributes, even the deleted references are returned. For example, for hive_process, deleted input and output tables are returned - Shwetha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46011/#review128517 ----------------------------------------------------------- On April 13, 2016, 4:12 p.m., Shwetha GS wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46011/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 4:12 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-622 > https://issues.apache.org/jira/browse/ATLAS-622 > > > Repository: atlas > > > Description > ------- > > Added soft delete which is enabled by default. Hard delete can be configured > using guice. Had to refactor entity deletes. > > Pending: > 1. > GraphBackedMetadataRepositoryDeleteEntitiesTest.testDisconnectUnidirectionalArrayReferenceFromStructAndTraitTypes > is disabled, need to debug > 2. Have to write more tests for soft deletes > 3. hive hook tests - have fixed some tests, 13/40 are still failing > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > f007a32 > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > a0f1d40 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > dbba926 > client/src/main/java/org/apache/atlas/AtlasClient.java cc87706 > repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java > 75d14f0 > > repository/src/main/java/org/apache/atlas/repository/graph/AtlasEdgeLabel.java > da2ad9a > > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java > b94ff5a > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > e7e8fb9 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 895f9df > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > 1d682bb > > repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java > 7011fdf > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java > 71e9028 > repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java > d07f89d > repository/src/test/java/org/apache/atlas/TestUtils.java a3cf929 > > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java > ea93cbf > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteEntitiesTest.java > 975d530 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java > b5440c2 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedReposiotrySoftDeleteTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java > 3f71eb3 > > repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java > 8ca3132 > > repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java > 1156b67 > repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 0289b1a > repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala 79ebfae > repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala > cd1c424 > repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala > 1a0fa20 > server-api/src/main/java/org/apache/atlas/RequestContext.java 943e4b8 > typesystem/src/main/java/org/apache/atlas/typesystem/IInstance.java ffe40a7 > typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java > 7857483 > typesystem/src/main/java/org/apache/atlas/typesystem/Struct.java 70deab2 > > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/DownCastStructInstance.java > d3b9a33 > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java > d742bb7 > > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java > 0fa4666 > > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java > 16c3a24 > typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java > 55ec91f > > typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java > eb1a15a > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java > b2e9f91 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > 23f6874 > > Diff: https://reviews.apache.org/r/46011/diff/ > > > Testing > ------- > > UTs, ITs > > > Thanks, > > Shwetha GS > >
