> On April 20, 2016, 4:36 a.m., Hemanth Yamijala wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java, > > line 422 > > <https://reviews.apache.org/r/46409/diff/1/?file=1351748#file1351748line422> > > > > We are resetting the table's name to older one. But the DB instance > > added to entities would still be a new DB name only. Is that a problem?
It wouldnt cause an issue in the normal flow but could cause it be inconsistent if the following updates to replace the table name, column, sd fail. So fixed it by replacing with old DB instance - Suma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46409/#review129681 ----------------------------------------------------------- On April 20, 2016, 9:54 p.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46409/ > ----------------------------------------------------------- > > (Updated April 20, 2016, 9:54 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-583 > https://issues.apache.org/jira/browse/ATLAS-583 > > > Repository: atlas > > > Description > ------- > > Fixed it by first renaming the columns, sd, partition keys and then renaming > the table so that the columns, sd, etc are not deleted/recreated again > becaused they are deduped based on their QualifiedName which has tableName as > part of it. > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > a28b4ac > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > 749294f > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java > f099e39 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 4c7ac70 > client/src/main/java/org/apache/atlas/AtlasClient.java 22a1726 > > Diff: https://reviews.apache.org/r/46409/diff/ > > > Testing > ------- > > Added tests in HiveHookIT > > > Thanks, > > Suma Shivaprasad > >
