> On April 21, 2016, 9:07 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py, > > line 67 > > <https://reviews.apache.org/r/46489/diff/1/?file=1354958#file1354958line67> > > > > older deployments won't have this value - should it be defaulted (like > > stack_name ablove)?
Yes, thanks for catching that and thanks for the review! - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46489/#review129958 ----------------------------------------------------------- On April 22, 2016, 1:57 a.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46489/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 1:57 a.m.) > > > Review request for atlas, John Speidel and Nate Cole. > > > Bugs: AMBARI-15981 > https://issues.apache.org/jira/browse/AMBARI-15981 > > > Repository: ambari > > > Description > ------- > > Even though the standalone Atlas uses embedded Hbase by default, the Ambari > Atlas configuration is set for Berkeley DB. Use embedded Hbase when > installing Atlas through Ambari. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml > a6deda1 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml > d64d48c > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-hbase-site.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml > 133b264 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py > 041e04e > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 3443016 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml > 42503b5 > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml > c787b40 > ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py > fd3ca81 > ambari-server/src/test/python/stacks/2.3/configs/default.json f87a4b8 > ambari-server/src/test/python/stacks/2.3/configs/secure.json 524484f > ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py a882189 > ambari-server/src/test/python/stacks/2.5/configs/default.json ddf4c9a > > Diff: https://reviews.apache.org/r/46489/diff/ > > > Testing > ------- > > Manual tested with Atlas install. > > Unit tests updated. > > mvn clean test > > > Thanks, > > Tom Beerbower > >
