----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45720/ -----------------------------------------------------------
(Updated April 25, 2016, 3:44 p.m.) Review request for atlas. Changes ------- update diff Bugs: ATLAS-631 https://issues.apache.org/jira/browse/ATLAS-631 Repository: atlas Description ------- 1. Introduce Versioning to Atlas Notification Payload (both ways) 2. For any messages that are not able to be processed, log the message do a separate log file for unprocessed messages. Diffs (updated) ----- distro/src/conf/atlas-log4j.xml 1ac4082 notification/src/main/java/org/apache/atlas/kafka/KafkaConsumer.java 029a072 notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 889af11 notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java PRE-CREATION notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java 596f988 notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java 1cadb99 notification/src/main/java/org/apache/atlas/notification/IncompatibleVersionException.java PRE-CREATION notification/src/main/java/org/apache/atlas/notification/MessageDeserializer.java PRE-CREATION notification/src/main/java/org/apache/atlas/notification/MessageVersion.java PRE-CREATION notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java ac285aa notification/src/main/java/org/apache/atlas/notification/VersionedMessage.java PRE-CREATION notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java PRE-CREATION notification/src/main/java/org/apache/atlas/notification/entity/EntityMessageDeserializer.java PRE-CREATION notification/src/main/java/org/apache/atlas/notification/hook/HookMessageDeserializer.java PRE-CREATION notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java PRE-CREATION notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java db34815 notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java PRE-CREATION notification/src/test/java/org/apache/atlas/notification/AbstractNotificationTest.java PRE-CREATION notification/src/test/java/org/apache/atlas/notification/MessageVersionTest.java PRE-CREATION notification/src/test/java/org/apache/atlas/notification/VersionedMessageTest.java PRE-CREATION notification/src/test/java/org/apache/atlas/notification/entity/EntityMessageDeserializerTest.java PRE-CREATION notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java 385c41f notification/src/test/java/org/apache/atlas/notification/hook/HookMessageDeserializerTest.java PRE-CREATION notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java 57b0eea typesystem/src/main/resources/atlas-log4j.xml 2bb49d3 Diff: https://reviews.apache.org/r/45720/diff/ Testing ------- New unit tests added. mvn clean test. Thanks, Tom Beerbower