> On April 22, 2016, 6:41 a.m., Shwetha GS wrote: > > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java, > > line 728 > > <https://reviews.apache.org/r/45948/diff/3/?file=1348562#file1348562line728> > > > > Why is this removed?
I removed it because it was not being called anywhere and duplicated code/functionality available elsewhere. If there is usage of this method that I missed, please advise. > On April 22, 2016, 6:41 a.m., Shwetha GS wrote: > > typesystem/src/main/java/org/apache/atlas/typesystem/types/AbstractDataType.java, > > line 48 > > <https://reviews.apache.org/r/45948/diff/3/?file=1348563#file1348563line48> > > > > rename to outputInProgress everywhere? I've removed the inProcess method argument. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45948/#review130045 ----------------------------------------------------------- On April 29, 2016, 7:24 p.m., David Kantor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45948/ > ----------------------------------------------------------- > > (Updated April 29, 2016, 7:24 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-645 > https://issues.apache.org/jira/browse/ATLAS-645 > > > Repository: atlas > > > Description > ------- > > ATLAS-645: In FieldMapping.output(), avoid infinite recursion when > IReferenceableInstance and IStruct instances reference each other. > > > Diffs > ----- > > > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java > af62442bfe5daa221079207acf361e1316cab3ad > > typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java > 36149bafff80b68ce176e82dcacac87035459362 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java > 89fcea6828c9e23c28a60952c3e4ca27c0667494 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/OutputStatus.java > PRE-CREATION > typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java > 54e344f5d6322a00ac7825ee8964f43a1552dcbe > > typesystem/src/test/java/org/apache/atlas/typesystem/types/OutputStatusTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/45948/diff/ > > > Testing > ------- > > Ran all unit and integration tests with no regressions. Added test cases > > > Thanks, > > David Kantor > >
