----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46444/#review131634 -----------------------------------------------------------
distro/src/conf/hbase/windows-hbase-site.xml.template (line 22) <https://reviews.apache.org/r/46444/#comment195655> Can you use system property and avoid using different config files for windows and non-windows - Shwetha GS On April 30, 2016, 12:04 a.m., David Kantor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46444/ > ----------------------------------------------------------- > > (Updated April 30, 2016, 12:04 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-659 > https://issues.apache.org/jira/browse/ATLAS-659 > > > Repository: atlas > > > Description > ------- > > ATLAS-659: Fix issues with using embedded HBase on Windows so that HBase > successfully starts and stops as part of Atlas startup/shutdown. > - Use correct HBase start and stop scripts for Windows > - Start HBase server after checking existing Atlas server > - Use Windows-specific template for hbase-site.xml - file URL for > hbase.rootdir needs three slashes to avoid error: "Illegal character in > authority at index 5" > - In TestMetadata.py, check mock for HBase Windows startup script > > > Diffs > ----- > > distro/src/bin/atlas_config.py 2b6bc825858cc5b36d55cba5b85b2087e8b4ecfe > distro/src/bin/atlas_start.py 4199e372c1357e490171fb1c9328c7529dbe0492 > distro/src/bin/atlas_stop.py 5653244cff141b9e9fd68cf6877c4d6ec952ee0f > distro/src/conf/hbase/windows-hbase-site.xml.template PRE-CREATION > distro/src/test/python/scripts/TestMetadata.py > bb74f2004501473fc726fe58e8f9ad1ead3e18f1 > > Diff: https://reviews.apache.org/r/46444/diff/ > > > Testing > ------- > > Ran all unit and integration tests with no regressions. > > > Thanks, > > David Kantor > >
