----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46922/#review131643 -----------------------------------------------------------
Fix it, then Ship it! addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java (line 422) <https://reviews.apache.org/r/46922/#comment195671> This function is not used anywhere. Can you remove addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 373) <https://reviews.apache.org/r/46922/#comment195673> Add a method(dgibridge, table) that returns the table qualified name addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 528) <https://reviews.apache.org/r/46922/#comment195670> Change the condition to be more readable - TableType.EXTERNAL_TABLE.equals(table.getTableType() || !table.isTemporary() || !skip typesystem/src/main/resources/atlas-application.properties (line 80) <https://reviews.apache.org/r/46922/#comment195674> no changes, revert - Shwetha GS On May 3, 2016, 12:50 a.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46922/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 12:50 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-626 > https://issues.apache.org/jira/browse/ATLAS-626 > > > Repository: atlas > > > Description > ------- > > Capturing temp table info only when lineage is involved. > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > 104c0c5 > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > 813177f > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java > dac5a18 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > b0d4c5c > typesystem/src/main/resources/atlas-application.properties a343a20 > > Diff: https://reviews.apache.org/r/46922/diff/ > > > Testing > ------- > > Added tests in HIveHookIT.testInsertIntoTempTable. > > > Thanks, > > Suma Shivaprasad > >
