----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46905/#review132559 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java (line 284) <https://reviews.apache.org/r/46905/#comment196773> the same case should be taken care of for maps? - Suma Shivaprasad On May 3, 2016, 8:26 p.m., David Kantor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46905/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 8:26 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-667 > https://issues.apache.org/jira/browse/ATLAS-667 > > > Repository: atlas > > > Description > ------- > > ATLAS-667: Enforce lower bound on references when deleting entities. If the > deletion candidate is the target of a reference with a non-zero lower bound, > disallow the delete if disconnecting the reference would reduce the reference > cardinality to zero. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java > 369a5d5aaaa8147f59773c25064375f767adf6b7 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java > ae215f99080047c6fe45b55ae0c5ad7c1ba600e2 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java > 8d2961ef5f9bae5ff40b03a9c00d5c1c51bf384b > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java > 5c59c8a7be68987738b23168ba92843cf229d61d > > server-api/src/main/java/org/apache/atlas/typesystem/exception/NullRequiredAttributeException.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/46905/diff/ > > > Testing > ------- > > Ran all unit and integration tests with no regressions. > > > Thanks, > > David Kantor > >