> On May 12, 2016, 9:21 a.m., Shwetha GS wrote: > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveLiteralRewriterTest.java, > > line 64 > > <https://reviews.apache.org/r/47107/diff/2/?file=1380622#file1380622line64> > > > > Isn't it possible to re-write this to expColumn = NUMBER_LITERAL?
since its cast(string) . Its not possible to since hive parser interprets that as string literal. - Suma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47107/#review132845 ----------------------------------------------------------- On May 12, 2016, 7:01 a.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47107/ > ----------------------------------------------------------- > > (Updated May 12, 2016, 7:01 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-619 > https://issues.apache.org/jira/browse/ATLAS-619 > > > Repository: atlas > > > Description > ------- > > Normlized all literals in a query and replacing them CONSTANT literals. > Storing recently run queries in a new attribute for hive_process - > recentQueries > > > Diffs > ----- > > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java > 8fced05 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java > 2494675 > > addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java > 4e2a06f > addons/hive-bridge/pom.xml eeb2aa4 > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > ffd5d22 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java > 6418770 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/ASTRewriter.java > PRE-CREATION > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/HiveASTRewriter.java > PRE-CREATION > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/LiteralRewriter.java > PRE-CREATION > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteContext.java > PRE-CREATION > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java > PRE-CREATION > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveLiteralRewriterTest.java > PRE-CREATION > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > da21195 > addons/hive-bridge/src/test/resources/hive-site.xml f1facb8 > > addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java > ab7e6ee > > addons/sqoop-bridge/src/test/java/org/apache/atlas/sqoop/hook/SqoopHookIT.java > 2820169 > > addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java > 267e228 > > addons/storm-bridge/src/main/scala/org/apache/atlas/storm/model/StormDataModel.scala > de67c39 > > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java > a017536 > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 9f69940 > repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java > 66e1365 > > typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala > 73b3526 > webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 70dce6b > webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java cdf6049 > > webapp/src/test/java/org/apache/atlas/web/resources/HiveLineageJerseyResourceIT.java > bc02f90 > > Diff: https://reviews.apache.org/r/47107/diff/ > > > Testing > ------- > > Added UT - HiveAStREwriteTest and IT asserttions in HiveHookIT > > > Thanks, > > Suma Shivaprasad > >
