> On May 5, 2016, 10:05 p.m., Suma Shivaprasad wrote: > > client/src/main/java/org/apache/atlas/EntityAuditEvent.java, line 66 > > <https://reviews.apache.org/r/46731/diff/2/?file=1363302#file1363302line66> > > > > why do we need String comparision here and not direct quals which > > would be faster? > > Suma Shivaprasad wrote: > any reason to still keep this as toString comparision instead of direct > ones? Can you pls explain?
I have fixed it - Shwetha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46731/#review131956 ----------------------------------------------------------- On May 19, 2016, 5:41 a.m., Shwetha GS wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46731/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 5:41 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-716 > https://issues.apache.org/jira/browse/ATLAS-716 > > > Repository: atlas > > > Description > ------- > > 1. Update/delete entity APIs return list of entities created, updated and > deleted > 2. Listeners are called for all the affected entities > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > 254e150 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 70100f1 > client/src/main/java/org/apache/atlas/AtlasClient.java b3ec95c > client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708 > client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION > client/src/test/java/org/apache/atlas/AtlasClientTest.java 0e80573 > > notification/src/main/java/org/apache/atlas/notification/MessageVersion.java > 3f16a9a > > notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java > 384f383 > > notification/src/main/java/org/apache/atlas/notification/VersionedMessageDeserializer.java > 290be59 > > notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java > 300cbb5 > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java > e8b55ef > > repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java > 540c308 > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java > 5b4bdbf > > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java > 8f11322 > > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java > a9e4f39 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java > 3604277 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > cccafc2 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > df28ab3 > > repository/src/main/java/org/apache/atlas/repository/graph/HardDeleteHandler.java > f8bbf73 > > repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java > aa78582 > > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java > a017536 > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java > 3fb128c > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 5195cbe > > repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java > be407a5 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java > 1aeedb5 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java > d2109d3 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java > d9e3ec9 > > repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java > 1f906ed > server-api/src/main/java/org/apache/atlas/RequestContext.java b1d87ea > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > 13d20d8 > typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java > 31f157e > webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java c6ed85d > > webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java > PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 709fec5 > webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java > 0f8bcb1 > webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java 7f20652 > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > 6985152 > > webapp/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > aa92bc0 > webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java > 2d510a0 > > Diff: https://reviews.apache.org/r/46731/diff/ > > > Testing > ------- > > UTs > > > Thanks, > > Shwetha GS > >
