[
https://issues.apache.org/jira/browse/ATLAS-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299610#comment-15299610
]
Hemanth Yamijala commented on ATLAS-812:
----------------------------------------
Tested this patch and found the following issues:
*Functionality*
* To add a term to an asset, the modal dialog that is coming up is flattening
the hierarchy of the terms. So, for e.g. if I define a business taxonomy
hierarchy as follows: default.orgs.finance and default.depts.finance, the list
shows finance twice, but without context it is difficult to say which finance
it is referring to.
* After adding business term to the asset, when we select the "Search Asset" on
the term, it fires an incorrect query where only the last part of the name of
the business term is used in the search. For e.g. it should be
{{taxonomy.term1.term2}}, instead of just term2. Also, the search should have a
back-tick (`) character around the term. i.e. it should be
{{`taxonomy.term1.term2`}}.
* Maybe this was not the focus of the patch, but there are some differences I
see between how terms and tags are treated. We should check from a UX
perspective if this is OK, and cover these in another JIRA:
** Associated Business terms are not being shown along side tags in the top
view of the Asset details page.
** Cannot currently add terms from the top view of Asset details page, but can
do the same for tags.
** Cannot currently add terms from the schema tab of Asset details page, but
can do the same for tags.
*Small usability suggestions*
* The search results table has the heading for terms as "Taxonomy", while what
we actually show is terms. In fact, we might hide the fact that there are
multiple taxonomies to begin with. Should we rename this heading to "Terms"
then?
* Not related to this patch, but the context menu on a business term says
"Search Asset". Should be "Search Assets".
* In the asset detail page, should we call the heading as "Terms" and "Tags"
instead of "Term" and "Tag". This would make it consistent with the search
details page.
* When selecting the tags or terms tab, the header of the columns should be
"Attributes" and not "Attribute"
What is working is the following:
* Adding terms to assets in the search page is firing the right API call to
associate the term
* The term gets shown correctly in the views of the asset details page.
* Searching for this term association using the right DSL query is working fine.
* Disassociating terms to assets is working fine from both the search results
view and the asset details view in the terms tab.
> Atlas UI - Associate Terms with Assets
> --------------------------------------
>
> Key: ATLAS-812
> URL: https://issues.apache.org/jira/browse/ATLAS-812
> Project: Atlas
> Issue Type: Bug
> Affects Versions: 0.7-incubating
> Reporter: Keval Bhatt
> Assignee: Keval Bhatt
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-812.patch
>
>
> As part of Business Catalog, it is important to have a feature to associate
> assets with terms. That feature is not yet been implemented. API is available
> for the same in ATLAS-491.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
