-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48280/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-515
    https://issues.apache.org/jira/browse/ATLAS-515


Repository: atlas


Description
-------

Attached patch provides a method to automatically create Kafka topics 
ATLAS_HOOK and ATLAS_ENTITIES with configured number of replicas.


Diffs
-----

  addons/falcon-bridge/pom.xml 14c6090 
  addons/hive-bridge/pom.xml 47e72e8 
  addons/storm-bridge/pom.xml b1a7a9b 
  distro/src/conf/atlas-application.properties 1cdd424 
  notification/pom.xml b3738db 
  notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 71029b0 
  notification/src/main/java/org/apache/atlas/hook/AtlasTopicCreator.java 
PRE-CREATION 
  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
1ee62d2 
  
notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java
 cb44fc6 
  notification/src/test/java/org/apache/atlas/hook/AtlasTopicCreatorTest.java 
PRE-CREATION 
  pom.xml eac95c8 

Diff: https://reviews.apache.org/r/48280/diff/


Testing
-------

* Started multiple Kafka brokers on single machine, configured number of 
replicas to be 2, started Atlas server and verified they got created correctly.
* Started multiple Kafka brokers on single machine, configured number of 
replicas to be 2, started Hive hook and verified it created ATLAS_HOOK 
correctly. Then started Atlas server and verified it by-passed ATLAS_HOOK 
creation, but did ATLAS_ENTITIES creation.
* Started one Kafka broker, onfigured number of replicas to be 2, started Atlas 
server and verified it received an exception as expected. But topic could still 
get auto-created and continued.
* Started 2 instances of Atlas server concurrently and verified topic creation 
is working fine.
* Existing UTs/ITs/new UTs pass.


Thanks,

Hemanth Yamijala

Reply via email to