> On June 16, 2016, 2:53 p.m., Madhan Neethiraj wrote: > > notification/src/main/java/org/apache/atlas/hook/AtlasHook.java, line 128 > > <https://reviews.apache.org/r/48723/diff/2/?file=1421382#file1421382line128> > > > > Retry attempts should send only failed messages - to avoid sending > > messages multiple times. Please review.
The sending of the messages is in the else part of the logic - when the retries are completed and we are ready to bail out. So, they do not send multiple times. > On June 16, 2016, 2:53 p.m., Madhan Neethiraj wrote: > > notification/src/main/java/org/apache/atlas/hook/FailedMessagesLogger.java, > > line 75 > > <https://reviews.apache.org/r/48723/diff/2/?file=1421383#file1421383line75> > > > > Would the log file location be deterministic - if there are multiple > > file appenders with different log file directories (for example host > > component's audit appender could write to a differnt location from log file > > location)? > > > > Wouldn't it be simpler to get fully qualified filename in > > atlas.notification.failed.messages.filename configuration? I am getting the configured appender for the root logger specifically. Also I take the first one in the list and break out. Would this not be only one? - Hemanth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48723/#review137984 ----------------------------------------------------------- On June 16, 2016, 12:21 p.m., Hemanth Yamijala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48723/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 12:21 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-901 > https://issues.apache.org/jira/browse/ATLAS-901 > > > Repository: atlas > > > Description > ------- > > The description of the approach is documented on JIRA here: > https://issues.apache.org/jira/browse/ATLAS-901?focusedCommentId=15331480&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15331480 > > > Diffs > ----- > > docs/src/site/twiki/Configuration.twiki 0e122fe > notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 71029b0 > notification/src/main/java/org/apache/atlas/hook/FailedMessagesLogger.java > PRE-CREATION > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > 1ee62d2 > > notification/src/main/java/org/apache/atlas/notification/NotificationException.java > d9d89df > notification/src/test/java/org/apache/atlas/hook/AtlasHookTest.java 16cb0f0 > > notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java > 219bd70 > > Diff: https://reviews.apache.org/r/48723/diff/ > > > Testing > ------- > > Tested by integrating with hive hook. Brought down Kafka when the hook has to > send messages. Ensured that the message is logged into the log file. > > Added some UTs for the changes. > > > Thanks, > > Hemanth Yamijala > >
