----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49357/#review140001 -----------------------------------------------------------
Ship it! Ship It! - Hemanth Yamijala On June 29, 2016, 2:58 p.m., keval bhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49357/ > ----------------------------------------------------------- > > (Updated June 29, 2016, 2:58 p.m.) > > > Review request for atlas, Gautam Borad, Madhan Neethiraj, Shwetha GS, and > Hemanth Yamijala. > > > Bugs: ATLAS-958 > https://issues.apache.org/jira/browse/ATLAS-958 > > > Repository: atlas > > > Description > ------- > > Patch include following changes. > > * Removed unused font (glyphicon) > * Added licence file to all js libraries (added grunt task to copy license > file to dist folder) > * Added all libraries license details in {atlas_home}/LICENSE.txt file > * Removed unused plugin (tree.js) > > > Diffs > ----- > > 3party-licenses/animate-LICENSE PRE-CREATION > 3party-licenses/bootstrap-sidebar-LICENSE PRE-CREATION > 3party-licenses/handlebars-LICENSE PRE-CREATION > 3party-licenses/hbs-LICENSE PRE-CREATION > 3party-licenses/require-handlebars-plugin-LICENSE PRE-CREATION > LICENSE 8f075f5 > dashboardv2/gruntfile.js 2f30f3b > dashboardv2/package.json 9ec4feb > dashboardv2/public/css/bootstrap-sidebar.css 5f9d5c3 > dashboardv2/public/css/font-awesome.min.css acce2ef > dashboardv2/public/css/fonts/FontAwesome.otf > 3ed7f8b48ad9bfab52eb03822fefcd6b77d2e680 > dashboardv2/public/css/fonts/fontawesome-webfont.eot > 9b6afaedc0fd7aaf927a07f82da9c11022251b8b > dashboardv2/public/css/fonts/fontawesome-webfont.svg d05688e > dashboardv2/public/css/fonts/fontawesome-webfont.ttf > 26dea7951a73079223b50653c455c5adf46a4648 > dashboardv2/public/css/fonts/fontawesome-webfont.woff > dc35ce3c2cf688c89b0bd0d4a82bc4be82b14c40 > dashboardv2/public/css/fonts/fontawesome-webfont.woff2 > 500e5172534171f678e01f7569d66f9257036a09 > dashboardv2/public/css/fonts/glyphicons-halflings-regular.eot > b93a4953fff68df523aa7656497ee339d6026d64 > dashboardv2/public/css/fonts/glyphicons-halflings-regular.svg 94fb549 > dashboardv2/public/css/fonts/glyphicons-halflings-regular.ttf > 1413fc609ab6f21774de0cb7e01360095584f65b > dashboardv2/public/css/fonts/glyphicons-halflings-regular.woff > 9e612858f802245ddcbf59788a0db942224bab35 > dashboardv2/public/css/fonts/glyphicons-halflings-regular.woff2 > 64539b54c3751a6d9adb44c8e3a45ba5a73b77f0 > dashboardv2/public/css/scss/breadcrumb.scss eaa89e7 > dashboardv2/public/css/scss/business-catlog.scss 824bf10 > dashboardv2/public/css/scss/form.scss 82bd960 > dashboardv2/public/css/scss/graph.scss 7c6571c > dashboardv2/public/css/scss/loader.scss 6c255c6 > dashboardv2/public/css/scss/login.scss c7237cc > dashboardv2/public/css/scss/main.scss e9fb452 > dashboardv2/public/css/scss/nav.scss 7277ae1 > dashboardv2/public/css/scss/old-style.scss f62c494 > dashboardv2/public/css/scss/override.scss 6fc1e1f > dashboardv2/public/css/scss/panel.scss ee85715 > dashboardv2/public/css/scss/search.scss 858b974 > dashboardv2/public/css/scss/tab.scss 5117efe > dashboardv2/public/css/scss/tag.scss 1a07ce2 > dashboardv2/public/css/scss/theme.scss b05f7a2 > dashboardv2/public/css/scss/tree.scss e6c8ebf > dashboardv2/public/index.html 59e2c7e > dashboardv2/public/js/main.js 95f64a1 > dashboardv2/public/js/views/business_catalog/MoveTermLayoutView.js 3add56a > dashboardv2/public/js/views/search/SearchLayoutView.js 083e515 > pom.xml 4e7d4fd > > Diff: https://reviews.apache.org/r/49357/diff/ > > > Testing > ------- > > After removing glyphicon --> did manual testing of UI using users of all 3 > groups. > > Did CRUD operations for Terms, Tags and verified Lineage graph generation > using hive queries. > > > Thanks, > > keval bhatt > >
