[ https://issues.apache.org/jira/browse/ATLAS-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375804#comment-15375804 ]
ATLAS QA commented on ATLAS-996: -------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12817789/rb49771.patch against master revision 99d5143. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:red}-1 javac{color}. The applied patch generated 158 javac compiler warnings (more than the master's current 154 warnings). {color:green}+1 javadoc{color}. There were no new javadoc warning messages. +1 checkstyle. The patch generated 0 code style errors. {color:red}-1 findbugs{color}. The patch appears to introduce 382 new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in : ./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.AdminJerseyResourceIT ./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.EntityJerseyResourceIT ./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.MetadataDiscoveryJerseyResourceIT ./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.TypesJerseyResourceIT Test results: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningswebapp.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningsplugin-classloader.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningsauthorization.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningscommon.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningsfalcon-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningsrepository.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningscatalog.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningsclient.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningsnotification.html Findbugs warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/newPatchFindbugsWarningstitan.html Javac warnings: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//artifact/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/410//console This message is automatically generated. > DSL queries with comparsions of many primitive types fail > --------------------------------------------------------- > > Key: ATLAS-996 > URL: https://issues.apache.org/jira/browse/ATLAS-996 > Project: Atlas > Issue Type: Bug > Affects Versions: trunk > Reporter: Jeffrey Hagelberg > Assignee: Jeffrey Hagelberg > Attachments: > org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest-output.txt, > org.apache.atlas.discovery.GraphBackedDiscoveryServiceTest.txt, rb49771.patch > > > We have a test case we've added in our git fork that compares attributes with > all of the various primitive types to literal values. These are very simple > quries such as "Person where (salary >= 200000)" for all of the different > comparison operators and data types. We just discovered that these tests > were failing in the titan 0.5.4 implementation with a ClassCastException (for > example, for double type, the literal was being interpreted in Gremlin as > integer literal, and it could not cast it to a double to do the comparison) . > We have put in a fix for this issue in our fork. This JIRA is to merge the > test case as well as the code that fixes the issue into the Atlas master. > We also discovered that GraphBackedSearchIndexer.initialize() leaves the > TitanManagement transaction open when it returns early because the global > indices already exist. That was fixed as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)