----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50146/#review142668 -----------------------------------------------------------
Ship it! Ship It! - Suma Shivaprasad On July 18, 2016, 5:10 p.m., Shwetha GS wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50146/ > ----------------------------------------------------------- > > (Updated July 18, 2016, 5:10 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-957 > https://issues.apache.org/jira/browse/ATLAS-957 > > > Repository: atlas > > > Description > ------- > > 1. Allow type names and attribute names with special characters. Titan > doesn't allow property keys with special characters. So, encoding property > keys in create index, set property, get property and search > 2. The property values can contain special characters > 3. DSL to gremlin converter, escaped " as its used around string and $ as its > used as variable denoter > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java > e5c0e46 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > 8c8134f > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 4f531e2 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > e240fb6 > > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java > 4c1f559 > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java > 4503899 > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 8add6c8 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java > 443dd4a > > Diff: https://reviews.apache.org/r/50146/diff/ > > > Testing > ------- > > Verified create type, create entity and search using DSL > > > Thanks, > > Shwetha GS > >
