----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50209/#review142902 -----------------------------------------------------------
client/src/main/java/org/apache/atlas/AtlasClient.java (line 1159) <https://reviews.apache.org/r/50209/#comment208565> change from "for" loop to "do" is to ensure that the loop will execute at least once, and clientResponse will not be null. The number of time the loop will excute will remain same as before - except for the case where "getNumOfRetries() == 0" webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java (line 90) <https://reviews.apache.org/r/50209/#comment208566> "authentication" object in line #94 can be different from the one in line #84/#85 - due to the assignment in line #88. webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java (line 97) <https://reviews.apache.org/r/50209/#comment208567> Yes, it will be helpful to add login failure attempt details to application log. - Madhan Neethiraj On July 20, 2016, 12:39 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50209/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 12:39 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1033 > https://issues.apache.org/jira/browse/ATLAS-1033 > > > Repository: atlas > > > Description > ------- > > Issues flagged by Coverity scan are fixed > > > Diffs > ----- > > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java > 1ed9619 > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > 0e86333 > > authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java > 25692e1 > > authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java > 23fc924 > client/src/main/java/org/apache/atlas/AtlasClient.java d3af6ad > client/src/main/java/org/apache/atlas/AtlasServiceException.java 2117a6b > common/src/main/java/org/apache/atlas/utils/ParamChecker.java edfe355 > notification/src/main/java/org/apache/atlas/hook/FailedMessagesLogger.java > 0b552d3 > > repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java > c6790de > > repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java > 6def78b > > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java > e74e57f > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java > 73445cb > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > b3711b5 > > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java > f4f9ec1 > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java > 58ef675 > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 578def0 > > titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java > fc8f2c4 > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java > 7ff7958 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/AbstractDataType.java > dc9cdf2 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java > befc705 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphTraversal.java > 5022aa6 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphWalker.java > db87cf9 > webapp/src/main/java/org/apache/atlas/Atlas.java db3e13d > webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 42bccec > webapp/src/main/java/org/apache/atlas/util/CredentialProviderUtility.java > 58cd318 > webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java cd820c6 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 0d25af7 > > webapp/src/main/java/org/apache/atlas/web/resources/MetadataDiscoveryResource.java > 256f7d3 > > webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java > b0fe6aa > > Diff: https://reviews.apache.org/r/50209/diff/ > > > Testing > ------- > > Ran quick_start.py successfully > > > Thanks, > > Madhan Neethiraj > >
