----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50311/#review143450 -----------------------------------------------------------
Jeff will need to review this more closely, as I don't have enough knowledge of scala to do a meaningful. Please remove any extra whitespace denoted by red blocks in the diff. - David Kantor On July 22, 2016, 2:05 p.m., Neeru Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50311/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 2:05 p.m.) > > > Review request for atlas, David Kantor and Jeff Hagelberg. > > > Bugs: atlas-737 > https://issues.apache.org/jira/browse/atlas-737 > > > Repository: atlas > > > Description > ------- > > Jira 737 Add count queries in dsl querries > > > Diffs > ----- > > dashboardv2/.gitignore cf187024a45782c79e4a47121f74bb3512d48238 > repository/src/main/scala/org/apache/atlas/query/Expressions.scala > 297aa2b8f917d5ae25da6a69901af60542082642 > repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala > 7de03c32edf16c1676db94179266e02928e01f35 > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala > d336f1ec6d7637ed6d05cd781c66ed5407632e88 > repository/src/main/scala/org/apache/atlas/query/QueryParser.scala > 4d2429ebe9e6734a111201db164ec6ce7ab50c32 > repository/src/main/scala/org/apache/atlas/query/Resolver.scala > cff92afe98a6215499a70a9ef00a937804abe73e > > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java > df3fe8713819d3837dfde2bbf14fb7cacf0bdea4 > repository/src/test/scala/org/apache/atlas/query/ParserTest.scala > 8f277fc160f12f839dd6f2cba4657cd41c68b1c6 > typesystem/.gitignore c7029f81f2e8162e4926aaa8a6cfc153615a0a96 > > Diff: https://reviews.apache.org/r/50311/diff/ > > > Testing > ------- > > Execute all the existing tests successfully. added new tests with count > > > Thanks, > > Neeru Gupta > >