> On Aug. 31, 2016, 5:22 a.m., Madhan Neethiraj wrote: > > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java, > > line 197 > > <https://reviews.apache.org/r/51514/diff/2/?file=1488664#file1488664line197> > > > > Does every request have its own 'uriInfo' object? If not, how does this > > method differentiate requests that include "responseType" query parameter > > from the ones that don't? > > Apoorv Naik wrote: > Yes, every request has it's own UriInfo object. > > Madhan Neethiraj wrote: > ok. EntityResource class is marked as @Singlton. Hence my question. If > multiple requests arrive simultaneously, would each call execution get its > own uriInfo member? (if yes, how does this work?). Please validate.
The @Context annotation allows you to inject instances of javax.ws.rs.core.HttpHeaders, javax.ws.rs.core.UriInfo, javax.ws.rs.core.Request, javax.servlet.HttpServletRequest, javax.servlet.HttpServletResponse, javax.servlet.ServletConfig, javax.servlet.ServletContext, and javax.ws.rs.core.SecurityContext objects. So these are treated specially and allows injection into singletons. The container will have a proxy of the Singleton class and hence the server is able to handle multiple requests simultaneously while allowing such injection. - Apoorv ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51514/#review147407 ----------------------------------------------------------- On Aug. 30, 2016, 3:44 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51514/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 3:44 p.m.) > > > Review request for atlas, Madhan Neethiraj and Suma Shivaprasad. > > > Repository: atlas > > > Description > ------- > > The bug states that the API response only shows one entity definition in the > response of an update/create call wherease the expectation seems to be of > getting the entire list of the entities that were created/updated. > > The fix adds the required capability by the means of a query parameter > responseType with the value as "full", if the API call is made with this > extra parameter, the response would contain an additional field called > "definitionList" which is of type JsonArray. If the parameter is unspecified, > the API response remains unaffected. > > > Diffs > ----- > > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 82016d0 > > Diff: https://reviews.apache.org/r/51514/diff/ > > > Testing > ------- > > > Thanks, > > Apoorv Naik > >
