----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51723/#review148661 -----------------------------------------------------------
Ship it! Ship It! - keval bhatt On Sept. 12, 2016, 9:05 a.m., Kalyani Kashikar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51723/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 9:05 a.m.) > > > Review request for atlas, keval bhatt, Madhan Neethiraj, Sarath Kumar > Subramanian, Shwetha GS, and Suma Shivaprasad. > > > Bugs: ATLAS-1149 > https://issues.apache.org/jira/browse/ATLAS-1149 > > > Repository: atlas > > > Description > ------- > > In hive column needs to be sorted based on its original column order. New > attribute "position" has been added to hive_column type which maintains the > column order number. UI needs to use this information to sort the column > based on this attribute on schema table & entity details page. > > This patch includes changes for sort column based on "position" attribute > > > Diffs > ----- > > dashboardv2/public/js/collection/BaseCollection.js b039e30 > dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js cc67d01 > dashboardv2/public/js/views/schema/SchemaLayoutView.js dc19619 > > Diff: https://reviews.apache.org/r/51723/diff/ > > > Testing > ------- > > Added hive-brigde jar in atlas-impl dir in hive hook > Created new attribute “position” for hive_column type with curl command. > Tested entity details page UI for hive_table entities by adding new tables in > hive beeline client. > In schema table the db column are sorted according to position attribute in > api. > > > Thanks, > > Kalyani Kashikar > >
