> On Sept. 12, 2016, 2:07 p.m., David Radley wrote: > > I am was thinking that a more intuitive API would be to follow the pattern > > used in the REST API for entities. So for entities with have > > .../entities/{entityguid}. So for consistancy we could have > > .../entities/{entityguid}/traitnames which would return all the traitnames > > for the entity. > > .../entities/{entityguid}/traitnames/{traitname} which would return the > > specified traitname for the entity.
It makes sense to have separate endpoints for all trait definitions and individual trait definition. I have made this change in the new patch. - Vimal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51800/#review148487 ----------------------------------------------------------- On Sept. 12, 2016, 11:09 a.m., Vimal Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51800/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 11:09 a.m.) > > > Review request for atlas. > > > Repository: atlas > > > Description > ------- > > Given entity id and trait name, support rest API that returns the trait > instance for the entity. Currently, the other way of getting it is > getEntity() which returns full entity with all trait instances > > > Diffs > ----- > > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 82016d0 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > a1988ef > > Diff: https://reviews.apache.org/r/51800/diff/ > > > Testing > ------- > > > Thanks, > > Vimal Sharma > >