----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52077/#review149896 -----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java (line 94) <https://reviews.apache.org/r/52077/#comment217662> Use constant for "columns". Also can remove .getValuesMap .get should work on Referenceable addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java (line 97) <https://reviews.apache.org/r/52077/#comment217663> why is column qualifiedName different from the convention we are using for hive_column instances which are referred to from the table. Why is clustername removed? - Suma Shivaprasad On Sept. 20, 2016, 9:07 a.m., Vimal Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52077/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 9:07 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-247 > https://issues.apache.org/jira/browse/ATLAS-247 > > > Repository: atlas > > > Description > ------- > > After a CTAS query, lineage relationship between source columns and > destination column can be captured. This information can be used to create a > column lineage process. > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java > PRE-CREATION > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > a3464a0 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java > 45f0bc9 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataTypes.java > e094cb6 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > a5838b4 > > Diff: https://reviews.apache.org/r/52077/diff/ > > > Testing > ------- > > > Thanks, > > Vimal Sharma > >
