-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52336/
-----------------------------------------------------------
(Updated Sept. 28, 2016, 9:10 a.m.)
Review request for atlas.
Changes
-------
Updated patch to only create new types from the model.json file
Bugs: ATLAS-1184
https://issues.apache.org/jira/browse/ATLAS-1184
Repository: atlas
Description
-------
ReservedTypesRegistrar registers the models for supported integrations like
hive, falcon, sqoop and storm. ReservedTypesRegistrar reads the model files and
registers the types defined in the model file. The check thats done to verify
if the model is already registered - checks for existence of first class type.
This will not work if we add more class types to the existing model or modify
the existing type to add optional attributes.
ReservedTypesRegistrar should check for every type in the model file. Also,
ReservedTypesRegistrar should do type update which does create if not exists,
and update if exists
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java
41c0155
repository/src/test/java/org/apache/atlas/TestUtils.java bd9df62
repository/src/test/java/org/apache/atlas/services/ReservedTypesRegistrarTest.java
d602bd8
Diff: https://reviews.apache.org/r/52336/diff/
Testing
-------
Thanks,
Vimal Sharma
