> On Oct. 4, 2016, 10:56 p.m., Vimal Sharma wrote: > > repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java, > > line 68 > > <https://reviews.apache.org/r/52533/diff/1/?file=1522437#file1522437line68> > > > > what is the need for this check? We are iterating over model files > > anyway. > > > > If there can be directories inside "models" directory, we should get > > the files inside those directories and call registerType.
the patches files go in "patches" directory inside models dir. So the structure will be: $ATLAS_HOME/models/patches/001-patch1.json $ATLAS_HOME/models/patches/002-patch2.json added check to ignore the directories inside models dir. - Sarath Kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52533/#review151459 ----------------------------------------------------------- On Oct. 4, 2016, 4:17 p.m., Sarath Kumar Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52533/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 4:17 p.m.) > > > Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad. > > > Bugs: ATLAS-1210 > https://issues.apache.org/jira/browse/ATLAS-1210 > > > Repository: atlas > > > Description > ------- > > for clients who have not updated to latest code, this patch adds the > "position" attribute to hive_column type and updates version to 2.0 > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java > 28078f4 > distro/src/main/assemblies/standalone-package.xml ff7b784 > > repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java > c269c3a > src/main/patches/001-hive_column_add_position.json PRE-CREATION > > Diff: https://reviews.apache.org/r/52533/diff/ > > > Testing > ------- > > on older builds - updates the type by adding new attribute and updates > version to 2.0 > new builds - ignore the patch since version is already in 2.0 > > > Thanks, > > Sarath Kumar Subramanian > >
