----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53133/#review153947 -----------------------------------------------------------
Ship it! Ship It! - Suma Shivaprasad On Oct. 24, 2016, 9:58 p.m., Jeff Hagelberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53133/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 9:58 p.m.) > > > Review request for atlas, David Kantor and Neeru Gupta. > > > Bugs: ATLAS-1195 > https://issues.apache.org/jira/browse/ATLAS-1195 > > > Repository: atlas > > > Description > ------- > > ATLAS-1195 : Clean up generation of Gremlin > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/groovy/AbstractGroovyExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/ArithmeticExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/BinaryExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/CastExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/ClosureExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/CodeBlockExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/ComparisonExpression.java > PRE-CREATION > > common/src/main/java/org/apache/atlas/groovy/ComparisonOperatorExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/FieldExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/FunctionCallExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/GroovyExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/GroovyGenerationContext.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/IdentifierExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/ListExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/LiteralExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/LogicalExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/RangeExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/TernaryOperatorExpression.java > PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/TypeCoersionExpression.java > PRE-CREATION > > common/src/main/java/org/apache/atlas/groovy/VariableAssignmentExpression.java > PRE-CREATION > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java > 22280d500af1954abd1587ccbf66b85b601ba737 > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java > b5407888cc078c1133904ef8ddd5e88ef3f1d789 > > repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java > 1133b489f1927bfbc8b3adcbd8d975f00a625d53 > > repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java > PRE-CREATION > > repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala > 3ccc53f8f1d3c9b45e93e02c815652df1def4548 > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala > 447622b29e7bfd2a9bb1322fc0322b1eabac2ea8 > > Diff: https://reviews.apache.org/r/53133/diff/ > > > Testing > ------- > > Ran entire Atlas build, no issues found. > > > Thanks, > > Jeff Hagelberg > >
