[ https://issues.apache.org/jira/browse/ATLAS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612808#comment-15612808 ]
David Kantor edited comment on ATLAS-1195 at 10/27/16 7:00 PM: --------------------------------------------------------------- +1 Review approved by [~suma.shivaprasad] Committed to trunk - thanks [~jnhagelb] was (Author: dkantor): Committed to trunk - thanks [~jnhagelb] > Clean up DSL Translation > ------------------------ > > Key: ATLAS-1195 > URL: https://issues.apache.org/jira/browse/ATLAS-1195 > Project: Atlas > Issue Type: Sub-task > Reporter: Jeffrey Hagelberg > Assignee: Jeffrey Hagelberg > Fix For: 0.8-incubating > > Attachments: rb53133.patch > > > Right now, the DSL translation logic is full if statements like if(TP2) then > do this otherwise do that. This needs to be cleaned up. We need classes > that represent each gremlin construct and subclasses for TP2 / TP3 when > appropriate. We should first look and see if the existing Expression classes > can be leveraged for this. We should also try to make this general enough so > that whatever logic we put in place can also be leveraged by the catalog > project to generate TP2/TP3 gremlin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)