----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53039/#review154202 -----------------------------------------------------------
repository/src/test/java/org/apache/atlas/TestUtilsV2.java (line 57) <https://reviews.apache.org/r/53039/#comment223691> can you move this to intg test . Would be useful for tests down the stream as well. The graph part could be moved out - Suma Shivaprasad On Oct. 20, 2016, 1:23 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53039/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 1:23 a.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1233 > https://issues.apache.org/jira/browse/ATLAS-1233 > > > Repository: atlas > > > Description > ------- > > Initial testing > > > UnitTests for the *DefStores > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java > 160f714047bfc626dc29e42694cf86f21ab250a8 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > 12047bfd80c6fb37b61dfd401b35f9e3dfb41043 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java > 663470790dda87ea982ab63f22b94d3d576fd4ee > repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java > 21e6d3f3a656bfea4cd03a31b92254354442f175 > repository/src/test/java/org/apache/atlas/TestUtils.java > 30071baaededfa954257fe2dcd74e53dac912c42 > repository/src/test/java/org/apache/atlas/TestUtilsV2.java PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java > PRE-CREATION > repository/src/test/resources/atlas-application.properties PRE-CREATION > > Diff: https://reviews.apache.org/r/53039/diff/ > > > Testing > ------- > > Passing unit tests for > 1. Retrieval cases > 2. Creation of typedefs > 3. Update typedefs (todo) > 4. Delete typedefs (todo) > > > Thanks, > > Apoorv Naik > >