----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53156/#review154445 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java (line 74) <https://reviews.apache.org/r/53156/#comment223998> setClassifications(other != null ? other.getClassifications() : null); webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 68) <https://reviews.apache.org/r/53156/#comment224001> Instead of using POST, consider using PUT with a different URL - like: @PUT @Path("guid/{guid}/partial") public EntityMutationResponse partialUpdateByGuid(@PathParam("guid") String guid, AtlasEntity entity) { // ... } webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 87) <https://reviews.apache.org/r/53156/#comment224003> I am not sure how widely PATCH is used - especially since firewalls might be configured to allow only few verbs like GET, POST, PUT, DELETE. I would suggest to use PUT, with the following path: @PUT @Path("/uniqueAttr/{typeName}/{attrName}") public EntityMutationResponse partialUpdateByUniqueAttribute(@PathParam("attrName") String attrName, @QueryParam("attrValue") String attrValue, AtlasEntity entity) throws Exception { // ... } webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 115) <https://reviews.apache.org/r/53156/#comment224011> I think an endpoint to retrieve by uniqueAttrValue would be useful. Given that attrValue might have characters like "/" (for example a path), it might be better to get attrValue as queryParam: @Path("/uniqueAttr/{typeName}/{attrName}") public AtlasEntity getByUniqueAttribute(@PathParam("typeName") String typeName, @PathParam("attrName") attrName, @QueryParam("attrValue") String attrValue) { // ... } webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 121) <https://reviews.apache.org/r/53156/#comment224018> Consider adding deleteByGuid() method as well - for completeness sake. webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 126) <https://reviews.apache.org/r/53156/#comment224015> same comment as in partialUpdateByUniqueAttribute() and getByUniqueAttribute() webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 159) <https://reviews.apache.org/r/53156/#comment224016> addClassification() ==> addClassifications() webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java (line 172) <https://reviews.apache.org/r/53156/#comment224017> updateClassification() ==> updateClassifications() - Madhan Neethiraj On Nov. 1, 2016, 8:47 p.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53156/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 8:47 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1241 > https://issues.apache.org/jira/browse/ATLAS-1241 > > > Repository: atlas > > > Description > ------- > > AtlasEntityHeader - for concise entity representation > AtlasEntityWithAssociations - for entity represenation with wither associated > classifications, terms etc > EntityRest - for single entity operations > EntitiesRest - for multiple entity operations > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityId.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 8bd472a > intg/src/test/java/org/apache/atlas/TestUtilsV2.java dcccc38 > pom.xml 62fc136 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > PRE-CREATION > webapp/pom.xml 82f307c > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java > PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/53156/diff/ > > > Testing > ------- > > > Thanks, > > Suma Shivaprasad > >
