----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53073/#review155670 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java (line 204) <https://reviews.apache.org/r/53073/#comment225739> Consider moving enum def to the top of the source file. Rename LineageInfoDirection ==> LineageDirection repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java (line 116) <https://reviews.apache.org/r/53073/#comment225723> since 'depth' is already handled in getLineageQuery(), it is not necessary to check the depth again here. Please review and remove. Please review getOutputLineageInfo() and getBothLineageInfo() as well. repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java (line 124) <https://reviews.apache.org/r/53073/#comment225744> Consider replacing the for/while loops with the following: for (List<AtlasEntityHeader> path : lineagePaths) { AtlasEntityHeader prev = null; for(AtlasEntityHeader entity : path) { if (!entities.containsKey(entity.getGuid())) { entities.put(entity.getGuid(), entity); } if (prev != null) { relations.add(new AtlasLineageRelation(entity.getGuid(), prev.getGuid()); } prev = entity; } } repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java (line 194) <https://reviews.apache.org/r/53073/#comment225748> Given that AtlasLineageInfo.relations is a list, consider using List to combine both relations (instead of Set). AtlasLineageInfo ret = inputLineage; ret.getRelations().addAll(outputLineage.getRelations()); ret.getGuidEnitiesMap().putAll(outputLineage.getGuidEnitiesMap()); ret.setDirection(LineageInfoDirection.BOTH); return ret; repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java (line 213) <https://reviews.apache.org/r/53073/#comment225750> if only List is expected from the query, consider throwing an error when any other type is returned. Please review line #220 as well for the same condition. - Madhan Neethiraj On Nov. 10, 2016, 11:24 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53073/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2016, 11:24 p.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma > Shivaprasad. > > > Bugs: ATLAS-1234 > https://issues.apache.org/jira/browse/ATLAS-1234 > > > Repository: atlas > > > Description > ------- > > Initial model and implementation for updated lineage rest apis for input, > output and full lineage for dataset entity. > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317 > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba > intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java > aabf269 > > repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java > PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/53073/diff/ > > > Testing > ------- > > unit test and integration test updated. > > > Thanks, > > Sarath Subramanian > >
