----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53653/#review155716 -----------------------------------------------------------
Just a few minor comments. Please set the JIRA number in this review and upload the patch once you have addressed the review comments. repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java (line 70) <https://reviews.apache.org/r/53653/#comment225787> Remove tab characters (here and other places) repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java (line 278) <https://reviews.apache.org/r/53653/#comment225786> General comment: There are a few other bug fixes that were made to Gremlin3ExpressionFactory in our fork since that file was contributed that have not been contributed back yet. It may make sense to include those in this patch. It's up to you. Sooner or later we'll need to get those contributed. repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java (line 285) <https://reviews.apache.org/r/53653/#comment225785> Please remove the added whitespace. repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java <https://reviews.apache.org/r/53653/#comment225788> Please explain why this test case is being removed. - Jeff Hagelberg On Nov. 11, 2016, 2:34 p.m., Neeru Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53653/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2016, 2:34 p.m.) > > > Review request for atlas and Jeff Hagelberg. > > > Repository: atlas > > > Description > ------- > > Merge branch 'master' into oms-750 > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java > a901b5127b3dcd2939fec2c642475d7aad869d8e > > repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java > 32189bc6dab4cc25748e7b6136dc0a89476012c7 > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala > ee58eee7b4b2c41cc8f6dc1e4952b83ed0c833df > repository/src/main/scala/org/apache/atlas/query/Resolver.scala > cff92afe98a6215499a70a9ef00a937804abe73e > repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java > 8851b793b0ca032efb57bd76ec9198822e1520c2 > > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java > 645fef1fb3abf8cd2d4abf4429b00c32837ef0c0 > > Diff: https://reviews.apache.org/r/53653/diff/ > > > Testing > ------- > > Executed all existing order by tests successfully. Added new tests to order > by with alias > > > Thanks, > > Neeru Gupta > >
