> On Dec. 6, 2016, 2:22 a.m., Suma Shivaprasad wrote: > > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java, line 197 > > <https://reviews.apache.org/r/54058/diff/4/?file=1573384#file1573384line197> > > > > add validations to have typename or supertype in the request to be > > provided mandatorily. Else it will end up running a query which may not be > > indexed. > > Apoorv Naik wrote: > I've added a todo section for this in the store class.
Will be adding this as a part of the actual V2 implementation. - Apoorv ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158102 ----------------------------------------------------------- On Dec. 13, 2016, 6:47 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54058/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 6:47 a.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1311 > https://issues.apache.org/jira/browse/ATLAS-1311 > > > Repository: atlas > > > Description > ------- > > ATLAS-1311: Integration tests for the V2 Entity APIs > > > Diffs > ----- > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 23a13ea3 > client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c > client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 72f41187 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > 84608d9d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 6b2b2166 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > 5756adb5 > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > dfd29b14 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 8a663c28 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > ac4f9f1a > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > cc98207c > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd > webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java > 62e1e578 > webapp/src/main/resources/spring-security.xml 4ba30255 > webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d > webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2 > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > ec62112f > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java > de0a459b > > webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java > 2a4babae > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 325c25b4 > > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java > 7e4db13f > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > b5af111f > > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java > c681a0f9 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java > ed37c3a1 > > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java > 87bf9a89 > > Diff: https://reviews.apache.org/r/54058/diff/ > > > Testing > ------- > > UTs and ITs are running fine. mvn clean install -Pdist was successful > > > Thanks, > > Apoorv Naik > >
